Comments on: Generic (n-ary) Tree in Java

By: vivin

vivin — Tue, 24 Aug 2010 16:07:27 +0000

I think the best way to go about it would be to create a Group object that maintains a list of Users. Then, your generic tree would be genericized by Group, meaning that the data element of each node is a Group object. This way you don’t need to represent Users as individual nodes. They can be wrapped up inside the Group object.

When you build up your tree, you first build up Group objects and add users to them. You then use the Group object to create a GenericTreeNode.

By: oliver

oliver — Tue, 24 Aug 2010 15:56:08 +0000

Hey,

Many companies have tons of Active Directory Groups, and there are group of groups, and it could be very tricky to assess how many group of groups there are.

I am trying to use your code in order to build a n-ary tree from these groups.

For each group stored in Active Directory there are :
- the members of this group it could “users” but also groups
- the groups that this group below to

I was wondering how to use your n-ary tree to build the n-ary trees in order to have a list of the trees and how deep they are. Any ideas ?

Many thanks, Oliver

I am using your code in order to build a tree from

By: vivin

vivin — Wed, 17 Feb 2010 17:20:03 +0000

@Guus
Ah, good point. Thanks for catching that! I’ll send you an email – thanks for taking the time to make a project. I do have a google code account – I should probably move this into that!

By: Guus

Guus — Wed, 17 Feb 2010 16:52:52 +0000

@vivin
Actually, I couldn’t wait and made a little Maven project out of it myself. I’ll be happy to send it to you, if you’d like me to.

There appears to be a small omission in the code: you’re not overriding Object.equals(Object obj) even though you intent to. Instead, you have GenericTreeNode.equals(GenericTreeNode obj).

Poke me via mail (I included it in the header of this comment) and I’ll send you a project archive.

By: vivin

vivin — Wed, 17 Feb 2010 16:20:10 +0000

@Guus Good point - I'll try to jar it up sometime and release it as a library!

By: Guus

Guus — Wed, 17 Feb 2010 09:31:10 +0000

Are you releasing this code as a project somewhere? It’d be nice to be able to simply include it as a library.

By: vivin

vivin — Mon, 01 Feb 2010 23:10:25 +0000

@Lobo I actually prefer the regex because it's more obvious what I'm doing. When using a substring, it's not immediately obvious (without comments) what you're doing. I also gravitate towards to regexes due to the fact that I've written a lot of Perl code. Regexes aren't as elegant in Java though.

By: Lobo

Lobo — Mon, 01 Feb 2010 18:13:04 +0000

I believe it’s a rough implementation of your idea.
Which one do you prefer? Using Pattern, Matcher etc over -
return (this.children.size()>0? str.substring(0, str.lenth()-2) : str ) + “]”;

By: vivin

vivin — Sun, 31 Jan 2010 17:26:37 +0000

@SteveO
I was trying to represent data that had parent-child relationships an arbitrary number of levels deep.

By: SteveO

SteveO — Sun, 31 Jan 2010 06:24:33 +0000

So what was the problem at work that necessitated this solution?